Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45635 )
Change subject: vendorcode/google: add SPD_PART_NUMBER_IN_CBI Kconfig option ......................................................................
Patch Set 16:
Patch Set 6:
Thanks for splitting the changes into multiple CLs Nick. I think the organization needs to be slightly different.
CL1: Add weak definition of mainboard_get_dram_part_num (Already done) CL2: Make changes in vendorcode/google/chromeos to provide mainboard_get_dram_part_num() definition using a newly added Kconfig CL3: Change mainboards to select the new Kconfig and drop their implementation of mainboard_get_dram_part_num() CL4: Update spd_bin.c to use mainboard_get_dram_part_num() if implement