Attention is currently required from: Patrick Georgi, Stefan Reinauer, Paul Menzel, Alex James.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60218 )
Change subject: xcompile: Support i686-elf toolchains
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS2:
I see. I can drop this change if it doesn't make sense to include it.
The other possibility is to make sure that everything is configured and enabled correctly in the asm code before we jump to the C code.
Also, while we do allow building with other compilers, we'd strongly recommend building with the coreboot toolchain. That keeps it compatible with other people in the community and helps to cut down on problems from the random toolchains that may be installed on everyone's systems.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60218
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibdf2cdd8b244822740c03935747184ebc5ca1512
Gerrit-Change-Number: 60218
Gerrit-PatchSet: 3
Gerrit-Owner: Alex James
theracermaster@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Georgi
patrick@coreboot.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Alex James
theracermaster@gmail.com
Gerrit-Comment-Date: Wed, 05 Jan 2022 18:02:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Stefan Reinauer
stefan.reinauer@coreboot.org
Comment-In-Reply-To: Alex James
theracermaster@gmail.com
Gerrit-MessageType: comment