Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44276 )
Change subject: drivers/spi/tpm: Re-organize the TPM Initialization ......................................................................
Patch Set 2:
Patch Set 2:
Patch Set 2:
Are you aware of Jes' work (CB:43741) or did the two of you just accidentally implement the same thing at the same time? This series is doing a bunch of things that I thought were handled better in Jes' version, I'm not sure if those were intentional changes?
I was aware of the requirement to cache the firmware version, but was not aware of the CL CB:43741. If the shared goals between these 2 CLs i.e. parsing and caching the CR50 Firmware version, can be split out as a separate CL, then we can drop this CL.
Looked at Jes's CL in detail now. Posted my comments there.