[coreboot-gerrit] Change in coreboot[master]: mb/google/kukui: Initialize display

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32511 )

Change subject: mb/google/kukui: Initialize display
......................................................................

Patch Set 60:

(2 comments)

https://review.coreboot.org/c/coreboot/+/32511/60/src/mainboard/google/kukui... 
File src/mainboard/google/kukui/mainboard.c:

https://review.coreboot.org/c/coreboot/+/32511/60/src/mainboard/google/kukui... 
PS60, Line 109: 	if (!*name)
> You're pointing this at an array, it can never be NULL. […]

Yes that's an array, so I was not testing if (name). But if the decoded EDID does not have valid field for ascii string, it can contain \0 so we may check if (*name).

https://review.coreboot.org/c/coreboot/+/32511/60/src/soc/mediatek/common/in... 
File src/soc/mediatek/common/include/soc/dsi_common.h:

https://review.coreboot.org/c/coreboot/+/32511/60/src/soc/mediatek/common/in... 
PS60, Line 73: 	u32 dsi_vfp_early_stop;  /* Available since MT8183 */
> Looks like this slipped into the wrong patch? (But I'm fine submitting it this way if you don't want […]

Done