Attention is currently required from: Raul Rangel, Kangheui Won, Julius Werner, Karthik Ramasubramanian.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68953 )
Change subject: security/vboot: Update build rules using x86 SHA extension ......................................................................
Patch Set 1:
(1 comment)
File src/security/vboot/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/68953/comment/7638f52b_ea8bf811 PS1, Line 26: ifeq ($(CONFIG_VBOOT_STARTS_BEFORE_BOOTBLOCK),y)
I think `ifeq ($(CONFIG_ARCH_VERSTAGE_X86_32)$(CONFIG_ARCH_VERSTAGE_X86_64),y)` […]
Actually, the help text of `VBOOT_X86_SHA256_ACCELERATION` says `Use sha extension for sha256 hash calculation`, so maybe we should put the logic in the Kconfig, instead of modifying Makefile.inc here.
``` select VBOOT_X86_SHA256_ACCELERATION if VBOOT && !VBOOT_STARTS_BEFORE_BOOTBLOCK ```
Also, the dependency of `VBOOT_X86_SHA256_ACCELERATION` can also be changed to `ARCH_VERSTAGE_X86_32 || ARCH_VERSTAGE_X86_64`.