Matthew Blecker has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56928 )
Change subject: mainboard/google/poppy/variants/atlas: Stop setting touchscreen probed=1 ......................................................................
mainboard/google/poppy/variants/atlas: Stop setting touchscreen probed=1
This allows the touchscreen ACPI device in Linux to re-enumerate when re-binding its I2C adapter device.
BUG=b:177350937 TEST=With Atlas DUT running CrOS top-of-tree build, tested new RW and new RO+RW built with this change applied in Atlas CrOS firmware branch.
Without this change, after re-binding the touchscreen's I2C adapter device using sysfs, the touchscreen ACPI and HID devices are absent, and the touchscreen is unresponsive.
With this change, the touchscreen ACPI and HID devices are re-created after re-binding its I2C adapter device, and the touchscreen becomes responsive again.
Signed-off-by: Matthew Blecker matthewb@chromium.org Change-Id: I7b90690b0591e8748d7a007f8cc9688d393e59db --- M src/mainboard/google/poppy/variants/atlas/devicetree.cb 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/56928/1
diff --git a/src/mainboard/google/poppy/variants/atlas/devicetree.cb b/src/mainboard/google/poppy/variants/atlas/devicetree.cb index e779ae4..4319948 100644 --- a/src/mainboard/google/poppy/variants/atlas/devicetree.cb +++ b/src/mainboard/google/poppy/variants/atlas/devicetree.cb @@ -273,7 +273,6 @@ register "generic.desc" = ""STM Touchscreen"" register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_E7_IRQ)" register "generic.speed" = "I2C_SPEED_FAST" - register "generic.probed" = "1" register "generic.has_power_resource" = "1" register "generic.disable_gpio_export_in_crs" = "1" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C22)"