[coreboot-gerrit] [L] Change in coreboot[main]: mb/asrock: Add Z87E-ITX (Haswell)

[Angel Pons (Code Review)]

Attention is currently required from: Máté Kukri, Nicholas Chin.

Angel Pons has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/81022?usp=email )

Change subject: mb/asrock: Add Z87E-ITX (Haswell)
......................................................................

Patch Set 3: Code-Review+1

(2 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/81022/comment/ea261532_4bad34f4?usp... :
PS3, Line 23: DVI
Connector is DVI-I, i.e. supports both DVI and VGA. Was this tested with a DVI-to-VGA passive adapter too?

File src/mainboard/asrock/z87e-itx/gma-mainboard.ads:

https://review.coreboot.org/c/coreboot/+/81022/comment/ace526ad_9204246e?usp... :
PS3, Line 12: DP1,
            :       DP2,
            :       DP3,
Only one of these is actually needed. Would be easy to tell which one from a coreboot log, with libgfxinit debug enabled, while the DP connector is plugged in.

If possible, adding comments about which port is which would be nice.