Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47311 )
Change subject: mb/google/zork: Power off fingerprint sensor on shutdown ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47311/3/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c:
https://review.coreboot.org/c/coreboot/+/47311/3/src/mainboard/google/zork/v... PS3, Line 354: if (slp_typ == SLP_TYP_S5) { I think this can be handled on the boot-up path. Currently, you have a check to configure the pads as GPO low when the device reboots. Instead it can be done for all paths which are not resuming from S3. Then you don't need the conditional here.