[coreboot-gerrit] [XS] Change in coreboot[master]: intelblocks/pep: Restrict TBT displays (DPOF) on S0ix transition to FWCM

[Usha P (Code Review)]

Attention is currently required from: Balaji Manigandan, Felix Singer, Hannah Williams, Jamie Ryu, Paul Menzel, Subrata Banik, Tarun Tuli, Utkarsh H Patel, Utkarsh H Patel, Vikrant Jadeja.

Usha P has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75717?usp=email )

Change subject: intelblocks/pep: Restrict TBT displays (DPOF) on S0ix transition to FWCM
......................................................................

Patch Set 4:

(7 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/75717/comment/05b6b073_7c89cbd6 :
PS3, Line 7: displays(DPOF)
> Please add a space before the (.

Done

https://review.coreboot.org/c/coreboot/+/75717/comment/9bc1ed97_26c8674a :
PS3, Line 7: .
> No periods in commit titles.

Done

https://review.coreboot.org/c/coreboot/+/75717/comment/9b478042_d488135f :
PS3, Line 9: DPOF(TBT Displays OFF) only
> Please add a space before the (.

Done

https://review.coreboot.org/c/coreboot/+/75717/comment/01b3517c_862cb8fb :
PS3, Line 9: Manager in
> … is in …

Done

https://review.coreboot.org/c/coreboot/+/75717/comment/fbd85e60_2a88c98b :
PS3, Line 9: needed
> needs

Done

https://review.coreboot.org/c/coreboot/+/75717/comment/10f004d3_ed7ed61e :
PS3, Line 9: IOM needed to be notified about DPOF(TBT Displays OFF) only when Firmware connection Manager in use during S0ix Entry/Exit.
> Reflow for 72 chars per line

Done

File src/soc/intel/common/block/acpi/pep.c:

https://review.coreboot.org/c/coreboot/+/75717/comment/b1ee2d8d_94e9bb47 :
PS3, Line 278: 	#if CONFIG(FIRMWARE_CONNECTION_MANAGER)
> Please don't use preprocessor ifs when possible. For cases like this, just go with C code. […]

Done