Attention is currently required from: Kapil Porwal, Angel Pons, Arthur Heymans, Eric Lai, Lean Sheng Tan.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74442 )
Change subject: Update fsp submodule to upstream master
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
@Subrata, could this related we drop some unused module in chrome tree?
Not sure how to deal with this, since Chromebook use our own FSP.
FSP used on chromeos devices are coming from chrome-internal repo and I don't think we can either redistribute those to upstream coreboot project or we are using direct blobs released by Intel (over FSP github repo). Hence, I don't think the CL is even relevant for us. this is more over to build the ADL using upstream coreboot (which covers chromeos devices as well).
Now coming to dropping unused FSP modules, that is only applicable for ADL-N FSP repo and we have cherry-picked those CLs into respective project FSP branch. Such logic is not applicable for ADL-P FSP repo and brya variants.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74442
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I88d954568b427ea288610710155014ae0f460ff9
Gerrit-Change-Number: 74442
Gerrit-PatchSet: 2
Gerrit-Owner: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Sun, 23 Apr 2023 16:38:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment