Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83974?usp=email )
Change subject: soc/intel/alderlake: Preserve eSOL for late CSE sync ......................................................................
soc/intel/alderlake: Preserve eSOL for late CSE sync
This patch prevents the eSOL screen from being wiped out on Alder Lake platforms that use late CSE sync (from ramstage). This allows the eSOL text message to remain visible until ramstage.
Currently, the eSOL only functions during the early boot phase (until romstage), so platforms like Nissa/Nirul and Trulo, which use CSE sync from ramstage, cannot display any eSOL messages to the user.
A future patch will ensure the eSOL remains relevant for CSE sync in ramstage, but this patch is necessary to avoid tearing down the IGD text mode when exiting romstage.
BUG=b:359814797 TEST=eSOL text mode is not torn down when exiting romstage.
Change-Id: I81548b4057ab95ce3da0dbc69703977baf0581f1 Signed-off-by: Subrata Banik subratabanik@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/83974 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Dinesh Gehlot digehlot@google.com --- M src/soc/intel/alderlake/romstage/romstage.c 1 file changed, 3 insertions(+), 1 deletion(-)
Approvals: Dinesh Gehlot: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/soc/intel/alderlake/romstage/romstage.c b/src/soc/intel/alderlake/romstage/romstage.c index 5ca16ae..f0c039e 100644 --- a/src/soc/intel/alderlake/romstage/romstage.c +++ b/src/soc/intel/alderlake/romstage/romstage.c @@ -227,7 +227,9 @@ * - Allow PEIM graphics driver to smoothly execute in ramstage if * RUN_FSP_GOP is selected */ - early_graphics_stop(); + if (!CONFIG(SOC_INTEL_CSE_LITE_SYNC_IN_RAMSTAGE)) + /* Keep eSOL active if CSE sync in ramstage config is enabled */ + early_graphics_stop();
if (CONFIG(ENABLE_EARLY_DMA_PROTECTION)) vtd_enable_dma_protection();