[coreboot-gerrit] Change in coreboot[master]: soc/qualcomm/qcs405: Handle invalid QUP and BLSP

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34523 )

Change subject: soc/qualcomm/qcs405: Handle invalid QUP and BLSP
......................................................................

soc/qualcomm/qcs405: Handle invalid QUP and BLSP

Print an error message and return if an invalid QUP or BLSP is
encountered. This prevents a possible null pointer dereference
of spi_clk.

Change-Id: I374e15ce899c651df9c2d3e0f1ec646e33d4bdb2
Signed-off-by: Jacob Garber 
Found-by: Coverity CID 1401086
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34523
Tested-by: build bot (Jenkins) 
Reviewed-by: Patrick Georgi 
---
M src/soc/qualcomm/qcs405/clock.c
1 file changed, 8 insertions(+), 4 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved

diff --git a/src/soc/qualcomm/qcs405/clock.c b/src/soc/qualcomm/qcs405/clock.c
index de42147..b7dd51b 100644
--- a/src/soc/qualcomm/qcs405/clock.c
+++ b/src/soc/qualcomm/qcs405/clock.c
@@ -235,12 +235,16 @@
    		spi_clk = (struct qcs405_clock *)
    				&gcc->blsp1_qup4_spi_clk;
    		break;
+		default:
+			printk(BIOS_ERR, "Invalid QUP %d\n", qup);
+			return;
    	}
-	} else if (blsp == 2)
+	} else if (blsp == 2) {
    	spi_clk = (struct qcs405_clock *)&gcc->blsp2_qup0_spi_clk;
-
-	else
-		printk(BIOS_ERR, "BLSP%d not supported\n", blsp);
+	} else {
+		printk(BIOS_ERR, "BLSP %d not supported\n", blsp);
+		return;
+	}

clock_configure(spi_clk, spi_cfg, hz, ARRAY_SIZE(spi_cfg));
 }