Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40525 )
Change subject: soc/mediatek/mt8183: High frequency of DRAM should use term settings ......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40525/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40525/7//COMMIT_MSG@10 PS7, Line 10: that large than larger than
https://review.coreboot.org/c/coreboot/+/40525/7//COMMIT_MSG@11 PS7, Line 11: should enable the term to improve the signal integrity. Is that mentioned in some datasheet?
https://review.coreboot.org/c/coreboot/+/40525/7/src/soc/mediatek/mt8183/dra... File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/40525/7/src/soc/mediatek/mt8183/dra... PS7, Line 1837: vref_begin = params->tx_vref[chn][rank] | (vref_range << 6);
Line longer than 80 characters.
The current line length limit is 96 characters.