[coreboot-gerrit] Change in coreboot[master]: soc/mediatek/mt8192: add clkbuf and srclken_rc MT6359P driver

[Hung-Te Lin (Code Review)]

Attention is currently required from: Roger Lu, Yu-Ping Wu, Yuchen Huang.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46878 )

Change subject: soc/mediatek/mt8192: add clkbuf and srclken_rc MT6359P driver
......................................................................

Patch Set 60:

(1 comment)

File src/soc/mediatek/mt8192/clkbuf.c:

https://review.coreboot.org/c/coreboot/+/46878/comment/0f580d3c_a1c5ad85 
PS60, Line 16: _BF_MASK
> I wonder if we should publicize _BF_MASK and _BF_VALUE (by removing the leading underscore). […]

I was expecting some easier way.

Ideally the bitfields API can be generalized by _BF_IMPL, which should be more generic than publishing BF_MASK and BF_VALUE.

What about changing _BF_IMPL to DEFINE_BITFIELD_API?

Then we can do

#define BUF_SET_FIELDS(addr, ...) \
 DEFINE_BITFIELD_API(buf_clrset32, addr, __VA_ARGS__)

And of course, the buf_write_field must be re-designed to buf_clrset32