build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31863 )
Change subject: src/arch: An upgrade of SMBIOS to latest version 3.2
......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/#/c/31863/8/src/arch/x86/smbios.c
File src/arch/x86/smbios.c:
https://review.coreboot.org/#/c/31863/8/src/arch/x86/smbios.c@559
PS8, Line 559: if (!(leaf_b.eax | leaf_b.ebx | leaf_b.ecx | leaf_b.edx )) {
space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31863/8/src/arch/x86/smbios.c@559
PS8, Line 559: if (!(leaf_b.eax | leaf_b.ebx | leaf_b.ecx | leaf_b.edx )) {
braces {} are not necessary for single statement blocks
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31863
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd2675ddd7196300019057f80a51bdd3b0e5b4e1
Gerrit-Change-Number: 31863
Gerrit-PatchSet: 8
Gerrit-Owner: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Francois Toguo Fotso
francois.toguo.fotso@intel.corp-partner.google.com
Gerrit-Comment-Date: Wed, 13 Mar 2019 20:53:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment