Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62964 )
Change subject: drivers/tpm/cr50: Use cr50_get_firmware_version in get_board_cfg
......................................................................
Patch Set 3:
(2 comments)
File src/drivers/tpm/cr50.c:
https://review.coreboot.org/c/coreboot/+/62964/comment/5befcabb_819cbe4a
PS3, Line 16: static struct cr50_firmware_version cr50_firmware_version;
Maybe just make this a static local in cr50_get_firmware_version() so it can't be used uninitialized?
https://review.coreboot.org/c/coreboot/+/62964/comment/655a1a72_8fa4cd6b
PS3, Line 104: if (!cr50_fw_supports_board_cfg(&cr50_firmware_version))
Does this have the same issue?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62964
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia6e5f4965a8852793d2f95e6eb21ea87860335a9
Gerrit-Change-Number: 62964
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Tue, 22 Mar 2022 01:14:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment