Attention is currently required from: Forest Mittelberg, Subrata Banik.
Jameson Thies has posted comments on this change by Jameson Thies. ( https://review.coreboot.org/c/coreboot/+/84404?usp=email )
Change subject: chromeec/ec_acpi: Define ACPI devices for USB-C ports using UCSI ......................................................................
Patch Set 3:
(4 comments)
File src/ec/google/chromeec/ec_acpi.c:
https://review.coreboot.org/c/coreboot/+/84404/comment/1b877769_e0909153?usp... : PS1, Line 169: bool ucsi_platform = google_chromeec_get_ucsi_enabled();
can we move this at line 182 ?
Done
https://review.coreboot.org/c/coreboot/+/84404/comment/6ffc4935_27a62540?usp... : PS1, Line 200: usb2_port = NULL; : usb3_port = NULL; : usb4_port = NULL;
for these case as well ?
I've added a NULL assignment when these are first defined but am leaving the assignment here. `get_usb_port_references` and `get_pld_from_usb_ports` won't always assign to the ports, so this is to prevent reusing values across ports.
https://review.coreboot.org/c/coreboot/+/84404/comment/0b8fc827_578bc32f?usp... : PS1, Line 203: orientation_switch = NULL; : usb_role_switch = NULL; : mode_switch = NULL; : retimer_switch = NULL;
can we set the default while declaring these local variables ?
Done
https://review.coreboot.org/c/coreboot/+/84404/comment/f4215841_04aec6ae?usp... : PS1, Line 230: .orientation_switch = orientation_switch, : .usb_role_switch = usb_role_switch, : .mode_switch = mode_switch, : .retimer_switch = retimer_switch,
is it okay to set `NULL` to `orientation_switch` and others as per ACPI spec? or we should keep it u […]
I am not seeing much in the ACPI specification about valid assignments to the orientation and retimer switches. But, this is what we currently do for other `typec_config` properties. The assignment to usb4_port isn't guaranteed in `get_usb_port_references`. The usbX_port properties will default to a NULL.