Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42706 )
Change subject: mb/amd/mandolin: maximize CBFS size
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42706/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42706/1//COMMIT_MSG@7
PS1, Line 7: mb/amd/mandolin: maximize CBFS size
How should reviewers verify, that your changed values are correct?
by looking at mandolin's fmap which is why I added that to the help text of the CBFS_SIZE option to not have a magic value there
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42706
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib829da0972bb7ec98f66fe8fe683289d91ad58dc
Gerrit-Change-Number: 42706
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 23 Jun 2020 12:18:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment