13 Feb
2021
13 Feb
'21
10:42 a.m.
Attention is currently required from: HAOUAS Elyes. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40369 )
Change subject: nb/i945: Drop unneeded loop ......................................................................
Patch Set 5:
(1 comment)
File src/northbridge/intel/i945/raminit.c:
https://review.coreboot.org/c/coreboot/+/40369/comment/7550f80a_3d6a5e71 PS5, Line 2177: MCHBAR32(UPMC3) |= (1 << 16); This toggles the bit back and forth. Why? I have no clue.
--
To view, visit https://review.coreboot.org/c/coreboot/+/40369
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iefa53ceaa4fb9dd7868ea59a21d9bd11f3bf27b9
Gerrit-Change-Number: 40369
Gerrit-PatchSet: 5
Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Comment-Date: Sat, 13 Feb 2021 10:42:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment