Attention is currently required from: Angel Pons, Felix Singer, Jan Philipp Groß, Máté Kukri, Paul Menzel.
Nicholas Chin has posted comments on this change by Jan Philipp Groß. ( https://review.coreboot.org/c/coreboot/+/82913?usp=email )
Change subject: mb/asrock: Add Fatal1ty Z87 Professional (Haswell)
......................................................................
Patch Set 8:
(2 comments)
File src/mainboard/asrock/fatal1ty_z87_professional/Kconfig:
https://review.coreboot.org/c/coreboot/+/82913/comment/e182ab7f_3a9b38ba?usp... :
PS8, Line 1: if BOARD_ASROCK_FATAL1TY_Z87_PROFESSIONAL
Add SPDX header
```suggestion
## SPDX-License-Identifier: GPL-2.0-only
if BOARD_ASROCK_FATAL1TY_Z87_PROFESSIONAL
```
File src/mainboard/asrock/fatal1ty_z87_professional/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/82913/comment/d8e5d9c7_2bca0b70?usp... :
PS8, Line 1: config BOARD_ASROCK_FATAL1TY_Z87_PROFESSIONAL
Add SPDX header
```suggestion
## SPDX-License-Identifier: GPL-2.0-only
config BOARD_ASROCK_FATAL1TY_Z87_PROFESSIONAL
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82913?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iae0b73d8e81be90ec3a2d5463df3ed170f603266
Gerrit-Change-Number: 82913
Gerrit-PatchSet: 8
Gerrit-Owner: Jan Philipp Groß
jeangrande@mailbox.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Máté Kukri
kukri.mate@gmail.com
Gerrit-Reviewer: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Máté Kukri
kukri.mate@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jan Philipp Groß
jeangrande@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 02 Jul 2024 00:55:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No