Attention is currently required from: Arthur Heymans, Hung-Te Lin, Nico Huber, Paul Menzel, Julius Werner.
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63660 )
Change subject: docs/coding_style: Clarify use of GCC extensions
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Patchset:
PS2:
Is there value in a section on what to do if a developer encounters a GCC extension that their compiler of choice doesn't support? "Wrap your code in a preprocessor guard and let us know via the mailing list if it gets too messy" or something to that effect?
I'm fine with saying that GCC is the officially-supported compiler of coreboot, but predicting the future is hard and there might be good reason to use another compiler in certain cases.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63660
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0d0eb90d6729fefeb131cdd573ad51f1884afe11
Gerrit-Change-Number: 63660
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Tue, 19 Apr 2022 05:11:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment