Attention is currently required from: David Milosevic, Julius Werner, Lean Sheng Tan, Martin L Roth, Maximilian Brune.
Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78285?usp=email )
Change subject: arch/arm64: Implement initial set of SMBIOS tables
......................................................................
Patch Set 15:
(1 comment)
File src/arch/arm64/smbios.c:
https://review.coreboot.org/c/coreboot/+/78285/comment/87048053_e80298df :
PS3, Line 50: void __weak smbios_cpu_get_core_counts(u16 *core_count, u16 *thread_count)
Okay, yeah, I agree you don't want to do full SMP setup here. […]
Since we can't guarantee that walking the FDT is the right approach in all cases, since TF-A has no formal spec that I know of (and TF-A-as-BL1 is only one path, not architecturally guaranteed), I'm just dropping this function.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78285?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iedae0f26f168bd6d3af866e35d9d39ddb01abc15
Gerrit-Change-Number: 78285
Gerrit-PatchSet: 15
Gerrit-Owner: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: David Milosevic
David.Milosevic@9elements.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: David Milosevic
David.Milosevic@9elements.com
Gerrit-Comment-Date: Fri, 19 Apr 2024 21:40:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Benjamin Doron
benjamin.doron00@gmail.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment