Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44023 )
Change subject: arch/x86/smbios.c: Split out weak functions
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44023/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44023/3//COMMIT_MSG@9
PS3, Line 9: To improve navigability
For my workflow it has the exact opposite effect. Also I have to grep
now for functions that were in the same spot for a decade or so. I
don't understand why we should allow such changes.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44023
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd2a4ba52b6b23aad8fd63e66ffa747d49ea713d
Gerrit-Change-Number: 44023
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Fri, 13 Nov 2020 21:00:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment