Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48221 )
Change subject: cpu/x86/lapic/secondary.S: Adapt for x86_64
......................................................................
Patch Set 3: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/48221/3/src/cpu/x86/lapic/secondary...
File src/cpu/x86/lapic/secondary.S:
https://review.coreboot.org/c/coreboot/+/48221/3/src/cpu/x86/lapic/secondary...
PS3, Line 36: __x86_64__
ENV_X86_64
https://review.coreboot.org/c/coreboot/+/48221/3/src/cpu/x86/lapic/secondary...
PS3, Line 64: secondary_stack
Is the stack 16bytes aligned?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48221
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5128ed574323025e927137870fb10b23d06bc01d
Gerrit-Change-Number: 48221
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 02 Dec 2020 07:30:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment