Attention is currently required from: Tim Chen.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48195 )
Change subject: mb/google/dedede/var/metaknight: Add LTE power on/off sequence
......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/google/dedede/variants/metaknight/gpio.c:
https://review.coreboot.org/c/coreboot/+/48195/comment/b8e1534c_dff70507
PS1, Line 11: PLTRST
For the same LTE module, vendor has recommended this - https://review.coreboot.org/c/coreboot/+/48623. Can you please check that?
https://review.coreboot.org/c/coreboot/+/48195/comment/05d2c25a_21b80624
PS1, Line 13:
Nit: Remove the extraneous line.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48195
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibff16129dfe2f1de2b1519049244aba4b3123e52
Gerrit-Change-Number: 48195
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Chen
Tim-Chen@quantatw.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raymond Wong
wongraymond@google.com
Gerrit-Reviewer: Tim Chen
tim-chen@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tim Chen
Tim-Chen@quantatw.com
Gerrit-Comment-Date: Mon, 11 Jan 2021 20:24:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment