Attention is currently required from: Lance Zhao, Jason Glenesk, Furquan Shaikh, Marshall Dawson, Tim Wawrzynczak, Nick Vaccaro, Julius Werner, Felix Held.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55502 )
Change subject: ChromeOS: Refactor ACPI CNVS generation
......................................................................
Patch Set 15:
(1 comment)
Patchset:
PS15:
just assumptions about the paths involved, snippets from dmesg:
[ 0.197888] ACPI BIOS Error (bug): Could not resolve symbol [\CRHW], AE_NOT_FOUND (20200925/dswload2-163)
Hmm.. Did I move CRHW, I don't think so. ACPI specs says all device objects should be under _SB though?
[ 0.197895] ACPI Error: AE_NOT_FOUND, During name lookup/catalog (20200925/psobject-220)
[ 0.197928] ACPI BIOS Error (bug): Could not resolve symbol [\CRHW.CNVS], AE_NOT_FOUND (20200925/dsfield-501)
This I did move. I will put it back to \CNVS if it makes this commit work.
looks like it breaks chromeos-ramoops as well
Did it break other than ramoops.asl?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55502
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id79af96bb6c038d273ac9c4afc723437fc1f3fc9
Gerrit-Change-Number: 55502
Gerrit-PatchSet: 15
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 26 Nov 2021 11:15:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment
