Attention is currently required from: Derek Huang, Eric Lai, Felix Held, Ivan Chen, Karthik Ramasubramanian, Paul Menzel.
Kevin Yang has posted comments on this change by Kevin Yang. ( https://review.coreboot.org/c/coreboot/+/84232?usp=email )
Change subject: mb/google/dedede/var/beadrix: Add LTE only daughterboard support
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84232/comment/4a53c8ba_6717632c?usp... :
PS4, Line 9: no port
What does *no port* mean?
Our DB has C1 port before, and add DB without C1 port
https://review.coreboot.org/c/coreboot/+/84232/comment/f3c6a7c1_8e1449c9?usp... :
PS4, Line 14: flash and check boot log on DUT.
What message do you check for?
Set fw config to DB_PORTS_LTE and check
1. fw_config match found: DB_PORTS=DB_PORTS_LTE <= show LTE present message
2. USB3 port 3: enabled 1 <= LTE port enable
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84232?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ica5a2d6e19421b132a0bdbad77806a17e2c1ce69
Gerrit-Change-Number: 84232
Gerrit-PatchSet: 4
Gerrit-Owner: Kevin Yang
kevin.yang@ecs.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Ivan Chen
yulunchen@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Kevin Yang
kevin.yang@ecs.corp-partner.google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Derek Huang
derekhuang@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Ivan Chen
yulunchen@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 18 Sep 2024 09:00:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org