Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32079 )
Change subject: drivers/intel/fsp2_0: Enable FSP feature to make use of same stack with bootloader
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/32079/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32079/2//COMMIT_MSG@7
PS2, Line 7: drivers/intel/fsp2_0: Enable FSP feature to make use of same stack with bootloader
1. Please short the summary.
> drivers/intel/fsp2_0: Use same stack with bootloader
2. What is the bootloader? GRUB is a bootloader for me.
https://review.coreboot.org/#/c/32079/2//COMMIT_MSG@10
PS2, Line 10:
Please describe the problem in more detail.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32079
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I673b4216d991d8ccad725c3931006a694184106c
Gerrit-Change-Number: 32079
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 28 Mar 2019 08:58:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment