Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43010 )
Change subject: soc/amd/common: fix eSPI virtual wire polarity encoding
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43010/1/src/soc/amd/common/block/in...
File src/soc/amd/common/block/include/amdblocks/espi.h:
https://review.coreboot.org/c/coreboot/+/43010/1/src/soc/amd/common/block/in...
PS1, Line 46: eSPI interrupts are active level high signals
Is this defined in the eSPI spec? I don't remember seeing that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43010
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7346bb0484506d96d7ab2e6d046ffa0571683a48
Gerrit-Change-Number: 43010
Gerrit-PatchSet: 1
Gerrit-Owner: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 02 Jul 2020 19:32:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment