Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libhwbase/+/43556 )
Change subject: Makefile: Add `-gnatw_R` to suppress spurious warning ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/libhwbase/+/43556/2/Makefile File Makefile:
https://review.coreboot.org/c/libhwbase/+/43556/2/Makefile@94 PS2, Line 94: GCC_MAJOR = $(shell echo __GNUC__ | $(CC) -E - 2>/dev/null | tail -1) Would prefer this above (between `CC = ` and `CFLAGS +=`) so we don't have to move it if it's ever needed somewhere else.
https://review.coreboot.org/c/libhwbase/+/43556/2/Makefile@95 PS2, Line 95: ADAFLAGS += $(if $(filter 10,$(GCC_MAJOR)),-gnatw_R) Please place directly below the other `+= -gnatwa` above.