Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30289 )
Change subject: soc/intel/common: Remove common chip config use_fsp_mp_init
......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/#/c/30289/11/src/soc/intel/common/block/cpu/mp_i...
File src/soc/intel/common/block/cpu/mp_init.c:
https://review.coreboot.org/#/c/30289/11/src/soc/intel/common/block/cpu/mp_i...
PS11, Line 141: if (CONFIG(USE_INTEL_FSP_MP_INIT))
I don't think this needs to be a separate function, "USE_INTEL_FSP_MP_INIT" is rather self-explanatory and it's used directly in other places, too.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30289
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4ee51276026748e8daf154f89e57095e8fe50280
Gerrit-Change-Number: 30289
Gerrit-PatchSet: 11
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-Comment-Date: Wed, 20 Mar 2019 16:39:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment