[coreboot-gerrit] [S] Change in coreboot[master]: soc/intel/{tgl,adl}: Hook up D3ColdEnable UPD to D3COLD_SUPPORT

[Michael Niewöhner (Code Review)]

Attention is currently required from: Sean Rhodes.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72800 )

Change subject: soc/intel/{tgl,adl}: Hook up D3ColdEnable UPD to D3COLD_SUPPORT
......................................................................

Patch Set 8:

(3 comments)

File src/device/Kconfig:

https://review.coreboot.org/c/coreboot/+/72800/comment/12e2a27f_b457c748 
PS4, Line 997: NO_S0IX_SUPPORT
as already said, there is a devicetree option.

https://review.coreboot.org/c/coreboot/+/72800/comment/f94ce603_abf71435 
PS4, Line 1004: Don't support D3Cold"
              : 	default n if NO_S0IX_SUPPORT
"Don't support" but Kconfig name says "support". What??

https://review.coreboot.org/c/coreboot/+/72800/comment/e50fb206_bf7cb64d 
PS4, Line 997: config NO_S0IX_SUPPORT
             : 	bool "Don't support S0IX suspend"
             : 	default n
             : 	help
             : 	  Select if the board only supports S3 and/or S4 and not S0IX
             : 
             : config D3COLD_SUPPORT
             : 	bool "Don't support D3Cold"
             : 	default n if NO_S0IX_SUPPORT
             : 	default y
             : 	help
             : 	  Select is any devices don't support D3Cold state
             : 
             : 
this change is doing more than just "hooking up", while the previous change, does not add these Kconfigs, while claiming so. guys....