Sathyanarayana Nujella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant
......................................................................
Patch Set 20:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42301/20/src/mainboard/google/volte...
File src/mainboard/google/volteer/variants/delbin/gpio.c:
https://review.coreboot.org/c/coreboot/+/42301/20/src/mainboard/google/volte...
PS20, Line 106: I2S0_PCH_TX_HP_RX_STRAP *
please change to:
I2S0_PCH_TX_HP_RX
https://review.coreboot.org/c/coreboot/+/42301/20/src/mainboard/google/volte...
PS20, Line 118: (GPP_S0,
Even we don't use this SNDW interface, we are configuring them, right?
Trying to understand.. if they should be as in : fw_config.c/sndw_disable_pads ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42301
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I59ce4720e0ffeeeb2c9440bb300686def80211ea
Gerrit-Change-Number: 42301
Gerrit-PatchSet: 20
Gerrit-Owner: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Ravishankar Sarawadi
ravishankar.sarawadi@intel.corp-partner.google.com
Gerrit-CC: Sathyanarayana Nujella
sathyanarayana.nujella@intel.com
Gerrit-Comment-Date: Tue, 21 Jul 2020 23:30:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment