Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36054 )
Change subject: soc/mediatek/mt8183: Compress calibration blob with LZ4
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36054/2/src/soc/mediatek/mt8183/Mak...
File src/soc/mediatek/mt8183/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/36054/2/src/soc/mediatek/mt8183/Mak...
PS2, Line 87: CBFS_PRERAM_COMPRESS_FLAG
Hmmm. When I try that last time it just failed... […]
correction. lzma needs to fetch whole buffer first (in ARM we don't have mmap so it's read into reserved space for CBFS cache) while lz4 can be decoded using same prepared buffer.
I think we want to stick with PRERAM_COMPRESS at the moment.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36054
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic3bd49d67ee6f80a0e4d8f6945744642611edf64
Gerrit-Change-Number: 36054
Gerrit-PatchSet: 2
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Ben Ho
Ben.Ho@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 18 Oct 2019 01:28:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment