Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42459 )
Change subject: [RFC] device: Add method for configuring bus master based on config option ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/42459/1/src/device/Kconfig File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/42459/1/src/device/Kconfig@519 PS1, Line 519: config PCI_ALLOW_BUS_MASTER
Since we are able to boot without setting this bit, we would like to disable bus mastering by defaul […]
Why, though? Security? To prevent PCI devices from initiating transfers?
In any case, please test this on a platform where coreboot code actually does something. With FSP, coreboot does not do much, and FSP is most likely setting bus master bits regardless of what this Kconfig says.
https://review.coreboot.org/c/coreboot/+/42459/4/src/device/pci_device.c File src/device/pci_device.c:
https://review.coreboot.org/c/coreboot/+/42459/4/src/device/pci_device.c@165... PS4, Line 1653: void pci_configure_bus_master(struct device *dev) void pci_dev_enable_bus_master(const struct device *dev)
https://review.coreboot.org/c/coreboot/+/42459/4/src/include/device/pci.h File src/include/device/pci.h:
https://review.coreboot.org/c/coreboot/+/42459/4/src/include/device/pci.h@13... PS4, Line 131: void pci_configure_bus_master(struct device *dev); void pci_dev_enable_bus_master(const struct device *dev);