Attention is currently required from: Julius Werner, Lean Sheng Tan.
Hello Julius Werner, Lean Sheng Tan, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83615?usp=email
to look at the new patch set (#3).
Change subject: util/cbfstool/cbfs-payload-linux: Do not compress bzImage ......................................................................
util/cbfstool/cbfs-payload-linux: Do not compress bzImage
Compressing the already compressed bzImage does not yield any fruit. If you are lucky it actually makes the image a little bit smaller. If you are unlucky the image actually gets bigger and since the compressing function is not checked for any erros, coreboot just builds successfully even though the payload is broken through compression.
Before this patch you could possibly get this error during compilation: ``` E: LZMA: LzmaEnc_Encode failed 9. ``` and your linux payload would end up something like this in CBFS: ``` FMAP REGION: COREBOOT Name Offset Type Size Comp .... fallback/payload 0x1c9c0 simple elf 511 none .... ```
That doesn't stop coreboot from finishing the build though, since we currently don't check for errors from the compression. That is an issue for another patch though.
Tested: Build and run QEMU-Q35 with Linux bzImage as payload.
Change-Id: I022982667515ce721d98af534414d9e336b5f35a Signed-off-by: Maximilian Brune maximilian.brune@9elements.com --- M util/cbfstool/cbfs-payload-linux.c 1 file changed, 16 insertions(+), 20 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/83615/3