Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48217 )
Change subject: soc/amd: factor out common SMI/SCI enums and function prototypes
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48217/1/src/soc/amd/common/block/in...
File src/soc/amd/common/block/include/amdblocks/smi.h:
https://review.coreboot.org/c/coreboot/+/48217/1/src/soc/amd/common/block/in...
PS1, Line 38: 0-57
0-57 won't be guaranteed to be consistent
i improved the comment in the next revision
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48217
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5a3858e793331a8d2ec262371fa22abac044fd4a
Gerrit-Change-Number: 48217
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 01 Dec 2020 21:17:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-MessageType: comment