Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45917 )
Change subject: nb/intel/pineview/memmap.c: Use `postcar_enable_tseg_cache` ......................................................................
nb/intel/pineview/memmap.c: Use `postcar_enable_tseg_cache`
Also adjust the comments accordingly.
Change-Id: I4cf11f205182fb18e92227e4d4dcdc8368a5598b Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/pineview/memmap.c 1 file changed, 4 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/45917/1
diff --git a/src/northbridge/intel/pineview/memmap.c b/src/northbridge/intel/pineview/memmap.c index bebe3a5..d26ae01 100644 --- a/src/northbridge/intel/pineview/memmap.c +++ b/src/northbridge/intel/pineview/memmap.c @@ -126,12 +126,10 @@ { uintptr_t top_of_ram;
- /* - * Cache 8 MiB region below the top of RAM and 2 MiB above top of RAM to cover both - * CBMEM and the TSEG region. - */ + /* Cache 8 MiB region below the top of RAM to cover CBMEM */ top_of_ram = (uintptr_t)cbmem_top(); postcar_frame_add_mtrr(pcf, top_of_ram - 8 * MiB, 8 * MiB, MTRR_TYPE_WRBACK); - postcar_frame_add_mtrr(pcf, northbridge_get_tseg_base(), northbridge_get_tseg_size(), - MTRR_TYPE_WRBACK); + + /* Cache the TSEG region */ + postcar_enable_tseg_cache(pcf); }