Attention is currently required from: Balaji Manigandan, Felix Singer, Jamie Ryu, Paul Menzel, Subrata Banik, Tarun Tuli, Usha P, Utkarsh H Patel, Utkarsh H Patel, Vikrant Jadeja.
Hannah Williams has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75717?usp=email )
Change subject: intelblocks/pep: Send All Monitor Off/On command only in FWCM case
......................................................................
Patch Set 8:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75717/comment/645aaa0d_bd04e259 :
PS3, Line 9: Firmware connection Manager
What is that?
https://docs.kernel.org/admin-guide/thunderbolt.html
"Connection manager is an entity running on the host router (host controller) responsible for enumerating routers and establishing tunnels"
https://review.coreboot.org/c/coreboot/+/75717/comment/e8b11580_ddbc9fc6 :
PS3, Line 9: IOM needed to be notified about DPOF(TBT Displays OFF) only when Firmware connection Manager in use during S0ix Entry/Exit.
Where is that documented?
I changed the commit message to be more descriptive. Please check
https://review.coreboot.org/c/coreboot/+/75717/comment/96de6066_727eb958 :
PS3, Line 10:
Please add a bug number.
Added BUG=
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75717?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I110fb971846f110e7d93a524ceda3bf4bfc15c13
Gerrit-Change-Number: 75717
Gerrit-PatchSet: 8
Gerrit-Owner: Usha P
usha.p@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Utkarsh H Patel
utkarsh.h.patel@intel.com
Gerrit-Reviewer: Utkarsh H Patel
utkarsh.h.patel@intel.corp-partner.google.com
Gerrit-Reviewer: Vikrant Jadeja
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Vikrant Jadeja
Gerrit-Attention: Utkarsh H Patel
utkarsh.h.patel@intel.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Attention: Usha P
usha.p@intel.com
Gerrit-Attention: Utkarsh H Patel
utkarsh.h.patel@intel.com
Gerrit-Comment-Date: Fri, 23 Jun 2023 16:36:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment