Attention is currently required from: Saurabh Mishra.
Felix Singer has posted comments on this change by Saurabh Mishra. ( https://review.coreboot.org/c/coreboot/+/83354?usp=email )
Change subject: soc/intel/ptl: Do initial Panther Lake SoC commit till bootblock ......................................................................
Patch Set 5:
(4 comments)
File src/soc/intel/pantherlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/83354/comment/f83ab776_3bcc9f7f?usp... : PS5, Line 3: config SOC_INTEL_PANTHERLAKE The original name was fine. Please change it back.
```suggestion config SOC_INTEL_PANTHERLAKE_BASE ```
https://review.coreboot.org/c/coreboot/+/83354/comment/0d53841c_9a75929b?usp... : PS5, Line 4: def_bool y This must not be enabled by default.
```suggestion bool ```
https://review.coreboot.org/c/coreboot/+/83354/comment/fbbebc43_33659e14?usp... : PS5, Line 29: if SOC_INTEL_PANTHERLAKE ```suggestion if SOC_INTEL_PANTHERLAKE_BASE ```
File src/soc/intel/pantherlake/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/83354/comment/87e59585_84f71bc8?usp... : PS5, Line 3: CONFIG_SOC_INTEL_PANTHERLAKE_A0 ```suggestion ifeq ($(SOC_INTEL_PANTHERLAKE_BASE),y) ```