Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik, YH Lin.
SH Kim has posted comments on this change by SH Kim. ( https://review.coreboot.org/c/coreboot/+/83346?usp=email )
Change subject: mb/google/brya/var/xol: Change touchpad I2C interrupt type to GPIO_INT ......................................................................
Patch Set 1:
(3 comments)
Patchset:
PS1:
IMO, the missing gpio. […]
If gpio config is not correct, touchpad would never work. The issue appeared after continuosly use of toupad.
File src/mainboard/google/brya/variants/xol/gpio.c:
https://review.coreboot.org/c/coreboot/+/83346/comment/83782472_d621e88d?usp... : PS1, Line 123: PAD_CFG_GPI_INT_LOCK(GPP_F14, NONE, LEVEL, LOCK_CONFIG),
PAD_CFG_GPI_IRQ_WAKE_LOCK(GPP_F14, NONE, LEVEL, INVERT, LOCK_CONFIG),
Actually this was the original config in baseboard/brya/gpio.c https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/main/src/m...
File src/mainboard/google/brya/variants/xol/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/83346/comment/027fba5f_0ce9762f?usp... : PS1, Line 347: register "generic.detect" = "1"
register "irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPP_F14_IRQ)" […]
We had the issue with this original config.