23 Oct
2022
23 Oct
'22
6:52 p.m.
Attention is currently required from: Sean Rhodes, Martin L Roth, Matt DeVillier, Stefan Reinauer.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68596 )
Change subject: payloads/edk2: Set the correct serial settings for AMD SOCs ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
because you don't get serial output on Picasso (and forward) without it
I'm confused. This looks like a bug in EDK2. It should parse the coreboot tables and set that PCD at runtime based on that information.
--
To view, visit https://review.coreboot.org/c/coreboot/+/68596
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I70630d21bbdb21f2aa8cbaeb3e842629b97af3ba
Gerrit-Change-Number: 68596
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes sean@starlabs.systems
Gerrit-Reviewer: Martin L Roth gaumless@gmail.com
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-CC: Matt DeVillier matt.devillier@gmail.com
Gerrit-Attention: Sean Rhodes sean@starlabs.systems
Gerrit-Attention: Martin L Roth gaumless@gmail.com
Gerrit-Attention: Matt DeVillier matt.devillier@gmail.com
Gerrit-Attention: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Sun, 23 Oct 2022 16:52:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier matt.devillier@gmail.com
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Gerrit-MessageType: comment