Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34809 )
Change subject: arch/x86: Add postcar_frame_common_mtrrs()
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34809/2/src/cpu/intel/car/romstage....
File src/cpu/intel/car/romstage.c:
https://review.coreboot.org/c/coreboot/+/34809/2/src/cpu/intel/car/romstage....
PS2, Line 36: if (!pcf->skip_common_mtrr)
I don't think we should be making these decisions here. This field should be checked in postcar_frame_common_mtrrs(). Or why not do this inside run_postcar_phase() and make the field inverted (fill common mtrrs).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34809
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id1f8b7682035e654231f6133a42909a36e3e15a1
Gerrit-Change-Number: 34809
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Fri, 09 Aug 2019 11:34:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment