HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43368 )
Change subject: src/include: Add missing includes ......................................................................
Patch Set 6:
(36 comments)
I've added comments to make the review easy. Thx
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/acpi/acpi_devic... File src/include/acpi/acpi_device.h:
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/acpi/acpi_devic... PS6, Line 362: BIT(2) needs <types.h>
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/acpi/acpi_ivrs.... File src/include/acpi/acpi_ivrs.h:
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/acpi/acpi_ivrs.... PS6, Line 113: uint8_t stdint
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/acpi/acpigen.h File src/include/acpi/acpigen.h:
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/acpi/acpigen.h@... PS6, Line 225: size_t stddef
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/acpi/acpigen_dp... File src/include/acpi/acpigen_dptf.h:
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/acpi/acpigen_dp... PS6, Line 54: uint8_t stdint
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/assert.h File src/include/assert.h:
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/assert.h@63 PS6, Line 63: uintptr_t stdint
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/boot/coreboot_t... File src/include/boot/coreboot_tables.h:
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/boot/coreboot_t... PS6, Line 14: uintptr_t stdint
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/cbfs.h File src/include/cbfs.h:
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/cbfs.h@16 PS6, Line 16: uint16_t stdint
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/cbfs.h@24 PS6, Line 24: size_t stddef
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/cpu/amd/mtrr.h File src/include/cpu/amd/mtrr.h:
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/cpu/amd/mtrr.h@... PS6, Line 72: uint64_t stdint
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/cpu/cpu.h File src/include/cpu/cpu.h:
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/cpu/cpu.h@10 PS6, Line 10: uintptr_t stdint
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/cpu/intel/l2_ca... File src/include/cpu/intel/l2_cache.h:
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/cpu/intel/l2_ca... PS6, Line 73: u32 stdint
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/cpu/x86/bist.h File src/include/cpu/x86/bist.h:
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/cpu/x86/bist.h@... PS6, Line 7: u32 stdint
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/cpu/x86/mp.h File src/include/cpu/x86/mp.h:
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/cpu/x86/mp.h@42 PS6, Line 42: void (*get_smm_info)(uintptr_t *perm_smbase, size_t *perm_smsize, stddef
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/cpu/x86/mp.h@79 PS6, Line 79: uintptr_t stdint
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/cpu/x86/smi_dep... File src/include/cpu/x86/smi_deprecated.h:
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/cpu/x86/smi_dep... PS6, Line 18: u32 stdint
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/crc_byte.h File src/include/crc_byte.h:
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/crc_byte.h@39 PS6, Line 39: size_t stddef
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/device/i2c_bus.... File src/include/device/i2c_bus.h:
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/device/i2c_bus.... PS6, Line 13: size_t stddef
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/device/i2c_simp... File src/include/device/i2c_simple.h:
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/device/i2c_simp... PS6, Line 26: u8 stdint
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/device/pci_ehci... File src/include/device/pci_ehci.h:
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/device/pci_ehci... PS6, Line 18: u8 stdint
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/device/pci_rom.... File src/include/device/pci_rom.h:
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/device/pci_rom.... PS6, Line 15: uint16_t stdint
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/device/pcix.h File src/include/device/pcix.h:
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/device/pcix.h@8 PS6, Line 8: struct device device.h
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/device/pcix.h@1... PS6, Line 10: u16 stdint
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/device/smbus_ho... File src/include/device/smbus_host.h:
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/device/smbus_ho... PS6, Line 24: size_t stddef
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/device/soundwir... File src/include/device/soundwire.h:
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/device/soundwir... PS6, Line 133: BIT(port) needs <types.h>
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/device_tree.h File src/include/device_tree.h:
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/device_tree.h@1... PS6, Line 148: size_t stddef
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/elog.h File src/include/elog.h:
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/elog.h@124 PS6, Line 124: u8 stdint
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/fmap.h File src/include/fmap.h:
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/fmap.h@32 PS6, Line 32: size_t stddef
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/fmap.h@39 PS6, Line 39: uint64_t stdint
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/memrange.h File src/include/memrange.h:
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/memrange.h@91 PS6, Line 91: size_t stddef
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/pc80/i8259.h File src/include/pc80/i8259.h:
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/pc80/i8259.h@71 PS6, Line 71: u16 stdint
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/region_file.h File src/include/region_file.h:
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/region_file.h@3... PS6, Line 36: size_t stddef
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/spd_cache.h File src/include/spd_cache.h:
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/spd_cache.h@19 PS6, Line 19: uint8_t stdint
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/spd_cache.h@20 PS6, Line 20: size_t stddef
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/spi_sdcard.h File src/include/spi_sdcard.h:
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/spi_sdcard.h@18 PS6, Line 18: size_t stddef
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/superio/hwm5_co... File src/include/superio/hwm5_conf.h:
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/superio/hwm5_co... PS6, Line 26: u8 stdint
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/timestamp.h File src/include/timestamp.h:
https://review.coreboot.org/c/coreboot/+/43368/6/src/include/timestamp.h@16 PS6, Line 16: uint64_t stdint