Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35880 )
Change subject: src/soc/intel: FSP2.0 platforms: add mainboard option to skip graphics init
......................................................................
Patch Set 4:
I see up to 6 commits here. In two independent groups:
* Add MAINBOARD_NO_FSP_GOP including its functionality (the depends on)
* Use it for the Supermicro boards
* Move CdClock setting on Skylake (this is different from the other platforms because some boards already set it)
* Adapt Icelake
* Add code to Apollo Lake
* Add code to Cannon Lake
I have no idea what `GtFreqMax` does and why it should depend
on the GOP execution. So I can only review the first two.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35880
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie3bd7f3dc4c795691a04d2eaba0e2458ee50aabb
Gerrit-Change-Number: 35880
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Hung-Te Lin
hungte@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Naresh Solanki
naresh.solanki@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Naresh Solanki
naresh.solanki.2011@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 26 Oct 2019 00:09:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment