Julius Werner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80775?usp=email )
Change subject: Revert "lib: Explicitly declare heap as NOLOAD" ......................................................................
Revert "lib: Explicitly declare heap as NOLOAD"
This reverts commit 99bf23c9e73c7492ee9d5c1f208bceedf3ff7cb5.
This patch causes the boot regression at depthcharge with below error signature. Able to boot to OS after reverting this patch.
``` Starting depthcharge on Rex... WARNING: can't convert coreboot GPIOs, 'lid' won't be resampled at runtime! WARNING: can't convert coreboot GPIOs, 'power' won't be resampled at runtime! fw_config match found: AUDIO=MAX98360_ALC5682I_I2S Looking for NVMe Controller 0x30069a60 @ 00:06:00 libc/lp_vboot.c:25 vboot_get_context(): vboot workbuf could not be initialized, error: 0x10080030 Ready for GDB connection. ```
Change-Id: I8d49e2dc49cd2935a9d8023c989869ec9558039e Signed-off-by: Subrata Banik subratabanik@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/80775 Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Kapil Porwal kapilporwal@google.com Reviewed-by: Caveh Jalali caveh@chromium.org Reviewed-by: Julius Werner jwerner@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/lib/program.ld 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved Nico Huber: Looks good to me, but someone else must approve Caveh Jalali: Looks good to me, approved Kapil Porwal: Looks good to me, approved
diff --git a/src/lib/program.ld b/src/lib/program.ld index 6d72d9e..21f4be8 100644 --- a/src/lib/program.ld +++ b/src/lib/program.ld @@ -131,7 +131,7 @@ #endif
#if ENV_HAS_HEAP_SECTION -.heap . (NOLOAD) : { +.heap . : { . = ALIGN(ARCH_POINTER_ALIGN_SIZE); _heap = .; . += CONFIG_HEAP_SIZE;