Kyösti Mälkki (kyosti.malkki@gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6118
-gerrit
commit c3a1000ee746ad9ebcd9e9de35ebf37940a0c43a Author: Kyösti Mälkki kyosti.malkki@gmail.com Date: Thu Jun 26 05:30:54 2014 +0300
AMD boards: Fix comment style and typos
Change-Id: Id630cc46b79a39e1786d42adbc21f3b9c3a051aa Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- src/northbridge/amd/agesa/family10/northbridge.c | 4 +++- src/northbridge/amd/agesa/family12/northbridge.c | 5 +++-- src/northbridge/amd/agesa/family14/northbridge.c | 4 ++-- src/northbridge/amd/agesa/family15/northbridge.c | 5 ++++- src/northbridge/amd/agesa/family15tn/northbridge.c | 5 ++++- src/northbridge/amd/agesa/family16kb/northbridge.c | 5 ++++- src/northbridge/amd/amdfam10/northbridge.c | 4 +++- src/northbridge/amd/amdk8/northbridge.c | 4 +++- 8 files changed, 26 insertions(+), 10 deletions(-)
diff --git a/src/northbridge/amd/agesa/family10/northbridge.c b/src/northbridge/amd/agesa/family10/northbridge.c index 886d112..6f2036b 100644 --- a/src/northbridge/amd/agesa/family10/northbridge.c +++ b/src/northbridge/amd/agesa/family10/northbridge.c @@ -881,7 +881,9 @@ static struct hw_mem_hole_info get_hw_mem_hole_info(void) } }
- //We need to double check if there is speical set on base reg and limit reg are not continous instead of hole, it will find out it's hole_startk + /* We need to double check if there is special set on base reg and limit reg + * are not continuous instead of hole, it will find out it's hole_startk. + */ if (mem_hole.node_id == -1) { resource_t limitk_pri = 0; for (i=0; i<sysconf.nodes; i++) { diff --git a/src/northbridge/amd/agesa/family12/northbridge.c b/src/northbridge/amd/agesa/family12/northbridge.c index 5701ed0..37b5977 100644 --- a/src/northbridge/amd/agesa/family12/northbridge.c +++ b/src/northbridge/amd/agesa/family12/northbridge.c @@ -315,8 +315,9 @@ static struct hw_mem_hole_info get_hw_mem_hole_info(void) }
#if 0 - // We need to double check if there is speical set on base reg and limit reg - // are not continous instead of hole, it will find out it's hole_startk + /* We need to double check if there is special set on base reg and limit reg + * are not continuous instead of hole, it will find out it's hole_startk. + */ if(mem_hole.node_id==-1) { resource_t limitk_pri = 0; struct dram_base_mask_t d; diff --git a/src/northbridge/amd/agesa/family14/northbridge.c b/src/northbridge/amd/agesa/family14/northbridge.c index 75ea76d..6a1bd63 100644 --- a/src/northbridge/amd/agesa/family14/northbridge.c +++ b/src/northbridge/amd/agesa/family14/northbridge.c @@ -302,8 +302,8 @@ static struct hw_mem_hole_info get_hw_mem_hole_info(void) } } #if 0 - /* We need to double check if there is speical set on base reg and limit reg - * are not continous instead of hole, it will find out it's hole_startk + /* We need to double check if there is special set on base reg and limit reg + * are not continuous instead of hole, it will find out it's hole_startk. */ if (mem_hole.node_id == -1) { resource_t limitk_pri = 0; diff --git a/src/northbridge/amd/agesa/family15/northbridge.c b/src/northbridge/amd/agesa/family15/northbridge.c index 05acf96..1ceefa7 100644 --- a/src/northbridge/amd/agesa/family15/northbridge.c +++ b/src/northbridge/amd/agesa/family15/northbridge.c @@ -622,7 +622,10 @@ static struct hw_mem_hole_info get_hw_mem_hole_info(void) break; // only one hole } } - //We need to double check if there is speical set on base reg and limit reg are not continous instead of hole, it will find out it's hole_startk + + /* We need to double check if there is special set on base reg and limit reg + * are not continuous instead of hole, it will find out it's hole_startk. + */ if (mem_hole.node_id == -1) { resource_t limitk_pri = 0; for (i=0; i<node_nums; i++) { diff --git a/src/northbridge/amd/agesa/family15tn/northbridge.c b/src/northbridge/amd/agesa/family15tn/northbridge.c index 51df5ee..f8a6954 100644 --- a/src/northbridge/amd/agesa/family15tn/northbridge.c +++ b/src/northbridge/amd/agesa/family15tn/northbridge.c @@ -596,7 +596,10 @@ static struct hw_mem_hole_info get_hw_mem_hole_info(void) break; // only one hole } } - //We need to double check if there is speical set on base reg and limit reg are not continous instead of hole, it will find out it's hole_startk + + /* We need to double check if there is special set on base reg and limit reg + * are not continuous instead of hole, it will find out it's hole_startk. + */ if (mem_hole.node_id == -1) { resource_t limitk_pri = 0; for (i=0; i<node_nums; i++) { diff --git a/src/northbridge/amd/agesa/family16kb/northbridge.c b/src/northbridge/amd/agesa/family16kb/northbridge.c index f421413..3e7b407 100644 --- a/src/northbridge/amd/agesa/family16kb/northbridge.c +++ b/src/northbridge/amd/agesa/family16kb/northbridge.c @@ -600,7 +600,10 @@ static struct hw_mem_hole_info get_hw_mem_hole_info(void) break; // only one hole } } - //We need to double check if there is speical set on base reg and limit reg are not continous instead of hole, it will find out it's hole_startk + + /* We need to double check if there is special set on base reg and limit reg + * are not continuous instead of hole, it will find out it's hole_startk. + */ if (mem_hole.node_id == -1) { resource_t limitk_pri = 0; for (i=0; i<node_nums; i++) { diff --git a/src/northbridge/amd/amdfam10/northbridge.c b/src/northbridge/amd/amdfam10/northbridge.c index 223cd9f..b47277a 100644 --- a/src/northbridge/amd/amdfam10/northbridge.c +++ b/src/northbridge/amd/amdfam10/northbridge.c @@ -735,7 +735,9 @@ static struct hw_mem_hole_info get_hw_mem_hole_info(void) } }
- //We need to double check if there is speical set on base reg and limit reg are not continous instead of hole, it will find out it's hole_startk + /* We need to double check if there is special set on base reg and limit reg + * are not continuous instead of hole, it will find out it's hole_startk. + */ if(mem_hole.node_id==-1) { resource_t limitk_pri = 0; for(i=0; i<sysconf.nodes; i++) { diff --git a/src/northbridge/amd/amdk8/northbridge.c b/src/northbridge/amd/amdk8/northbridge.c index ee5dfd2..1abac51 100644 --- a/src/northbridge/amd/amdk8/northbridge.c +++ b/src/northbridge/amd/amdk8/northbridge.c @@ -698,7 +698,9 @@ static struct hw_mem_hole_info get_hw_mem_hole_info(void) } }
- //We need to double check if there is speical set on base reg and limit reg are not continous instead of hole, it will find out it's hole_startk + /* We need to double check if there is special set on base reg and limit reg + * are not continuous instead of hole, it will find out it's hole_startk. + */ if(mem_hole.node_id==-1) { u32 limitk_pri = 0; for(i=0; i<8; i++) {