[coreboot-gerrit] [M] Change in coreboot[main]: soc/amd/common/spi: Create header for SPI defines

[Ana Carolina Cabral (Code Review)]

Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier.

Ana Carolina Cabral has posted comments on this change by Ana Carolina Cabral. ( https://review.coreboot.org/c/coreboot/+/84917?usp=email )

Change subject: soc/amd/common/spi: Create header for SPI defines
......................................................................

Patch Set 2:

(3 comments)

This change is ready for review.

Commit Message:

https://review.coreboot.org/c/coreboot/+/84917/comment/b1b5865b_832fcd4e?usp... :
PS1, Line 9: to header file
> they're already in a header file, so perhaps "a separate header file" instead?

Done

File src/soc/amd/common/block/include/amdblocks/spi_defs.h:

https://review.coreboot.org/c/coreboot/+/84917/comment/92288c99_ac221b5a?usp... :
PS1, Line 54: #define SPI_FIFO_LAST_BYTE		0xc6 /* 0xc7 for Cezanne */
> out of scope for this patch, but perhaps use `#if CONFIG(SOC_AMD_CEZANNE) ... […]

Thanks, Matt, I will do this in a separate patch 😊

https://review.coreboot.org/c/coreboot/+/84917/comment/9bd12256_89300669?usp... :
PS1, Line 63: AMD_BLOCK_DATA_FABRIC_DEFS_H
> update comment :)

Done