Attention is currently required from: Furquan Shaikh, Jamie Ryu, Paul Menzel, Subrata Banik, Raj Astekar, Patrick Rudolph.
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51723 )
Change subject: *x86: Support x2apic mode
......................................................................
Patch Set 6:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51723/comment/3a0b4766_fdc9916d
PS5, Line 7: src/*/x86 :
- Please remove the space before the colon. […]
Done
https://review.coreboot.org/c/coreboot/+/51723/comment/ca7efc1d_3bdbc003
PS5, Line 9: Implement x2apic mode as existing code only supports apic mode
- Please add dot/period to the end of sentences. […]
Done
https://review.coreboot.org/c/coreboot/+/51723/comment/205d6d67_c3d3e562
PS5, Line 14: cat /proc/cpuinfo | grep "apicid"
On what board? […]
example log is attached. Board is new platform which is not upstreammed yet. Will be upstreammed once we get legal approval.
File src/cpu/x86/lapic/lapic.c:
https://review.coreboot.org/c/coreboot/+/51723/comment/cbe7e526_4de3b3cc
PS5, Line 50: printk(BIOS_DEBUG, " apic_id: 0x%x ", lapicid());
Why does this need to be changed?
x2apic is 16bit while apic is 8bit
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51723
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0bb729b0521fb9dc38b7981014755daeaf9ca817
Gerrit-Change-Number: 51723
Gerrit-PatchSet: 6
Gerrit-Owner: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Raj Astekar
raj.astekar@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 01 Apr 2021 22:13:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment