[coreboot-gerrit] Change in coreboot[master]: soc/intel: Fix regression with hidden PCI devices

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34285 )

Change subject: soc/intel: Fix regression with hidden PCI devices
......................................................................

Patch Set 3:

(1 comment)
> Patch Set 3:
>
> Also we have pci_s_read_config() that takes BDF as argument, no need for device node pointer. I can use that on code like p2sb_hide() and p2sb_unhide():

Why not do it for all devices that are currently accessed using PCH_DEV_* i.e. just use _s_ variant to pass in PCH_DEVFN_* and get rid of all PCH_DEV_* completely.

https://review.coreboot.org/c/coreboot/+/34285/3/src/device/device_const.c 
File src/device/device_const.c:

https://review.coreboot.org/c/coreboot/+/34285/3/src/device/device_const.c@2... 
PS3, Line 243: BUG: %s requests hidden 00:%02x.%d\
> Maybe I mentioned earlier that I find soc/pci_devs.h most disgusting use of preprocessor.

Me too!